AWS Opsworks tests bring their own IAM objects #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we assumed the existence of some default objects that most Opsworks users have because the Opsworks console creates them by default when a new stack is created. However, that meant that these tests wouldn't work correctly for anyone who either had never used Opsworks via the UI or who had never accepted the default of having the console create some predefined IAM objects to use. It may also have led to some weird failures if a particular user had customized the settings for these default objects. Now the tests create suitable IAM roles, a policy and an instance profile and use these when creating Opsworks stacks, avoiding any dependency on any pre-existing objects. This fixes #3998.
apparentlymart
changed the title
|
LGTM. |
jen20
added a commit
that referenced
this pull request
Nov 25, 2015
provider/aws: AWS Opsworks tests bring their own IAM objects
3 tasks
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we assumed the existence of some default objects that most Opsworks users have because the Opsworks console creates them by default when a new stack is created.
However, that meant that these tests wouldn't work correctly for anyone who either had never used Opsworks via the UI or who had never accepted the default of having the console create some predefined IAM objects to use. It may also have led to some weird failures if a particular user had customized the settings for these default objects.
Now the tests create suitable IAM roles, a policy and an instance profile and use these when creating Opsworks stacks, avoiding any dependency on any pre-existing objects.
This fixes #3998.