Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to change Heroku organization TypeString to a TypeList #406

Merged
merged 2 commits into from
Oct 21, 2014
Merged

Proposal to change Heroku organization TypeString to a TypeList #406

merged 2 commits into from
Oct 21, 2014

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Oct 14, 2014

Instead of a simple string value for organization (added in #389), use a TypeList and allow Locked and Personal values as well.

Usage:

resource "heroku_app" "web" {
  name         = "catsby-test-app"
  region       = "us"
  organization {
    name = "catsby"
    locked = true
    personal = false
  }
}

This won't be backwards compatible though, unless you know a trick for supporting both :/

@mitchellh
Copy link
Contributor

No tricks, I think we just push the change since its so new into 0.3.1 and apologize. :( What is locked and personal ?

@catsby
Copy link
Contributor Author

catsby commented Oct 15, 2014

Locked is an access control thing

Basically everyone in an org can "join" and app, unless an Admin locks it.

The personal flag applies to when a default org is selected:

It's use case is illustrated with the CLI; I'm not sure it fits here.

In hindsight, I'm a bit indifferent about pulling this in. Locked makes sense I suppose, but this addition may not be a thing that's really needed. ¯_(ツ)_/¯

@mitchellh
Copy link
Contributor

Bringin it in. Thanks!

mitchellh added a commit that referenced this pull request Oct 21, 2014
Proposal to change Heroku organization TypeString to a TypeList
@mitchellh mitchellh merged commit 98f104d into hashicorp:master Oct 21, 2014
@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants