provider/aws: securitygroup name_prefix

[stack72]

Fixes #4152

Adding the ability to generate a securitygroup name-prefix

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSSecurityGroup_' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSSecurityGroup_ -timeout 90m
=== RUN   TestAccAWSSecurityGroup_namePrefix
--- PASS: TestAccAWSSecurityGroup_namePrefix (2.22s)

[catsby]

I think this error message is confusing, since we don't specify what 255 actually is. Some people will figure it out, but I don't think it adds anything. The API says the limit is 255 characters as well, so I'm not sure why we error if the length is over 100 (unless I'm misunderstanding something about Go's len function)

[stack72]

I'm just trying a punt in the dark and using a 100 character limit for the name_prefix.

[stack72]

@catsby ^^

[catsby]

ah, I see, the 255 is the combination of the two, my bad 😆

[stack72]

@catsby anything you want done with this? or can it be merged?

[catsby]

1 note on the error message, otherwise it looks good

[catsby]

Sorry for the hold up, this looks good!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.