Fix AWS RDS cross-region read replica always being placed in default VPC #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hashicorp#4192 by honouring the `db_subnet_group_name` parameter when creating a cross-region read replica.
nTraum
force-pushed
the
db_subnet_aws_read_replica
branch
from
9724ee4 to
1cd2fea
Compare
nTraum
changed the title
|
Hey @nTraum – thanks for the patch 😄 This looks great! I'll take it for a spin and see if we need anything else, like exporting the ARN if we aren't already, but at first glance it looks good 👍 |
| @@ -271,6 +271,7 @@ func resourceAwsDbInstanceCreate(d *schema.ResourceData, meta interface{}) error | |||
| CopyTagsToSnapshot: aws.Bool(d.Get("copy_tags_to_snapshot").(bool)), | |||
| DBInstanceClass: aws.String(d.Get("instance_class").(string)), | |||
| DBInstanceIdentifier: aws.String(d.Get("identifier").(string)), | |||
| DBSubnetGroupName: aws.String(d.Get("db_subnet_group_name").(string)), | |||
There was a problem hiding this comment.
For what it's worth, I removed this line in e52af33 . It should only be conditionally set, as you've done below in 292-295
|
Sure, thanks for taking care of it! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4192 by honouring the
db_subnet_group_nameparameter when creating a cross-region read replica.❗ These are my very first (baby-)steps in Go so I might missed something obvious. 😁 Maybe @catsby can take a look, thanks for pointing me into the right direction!
I tested this locally with my patched version, is that "good enough"? Looking forward to some feedback.
Btw your documentation & provided dev environment via Vagrant is outstanding, appreciate the effort. Working on terraform, even as go newbie, is a breeze!