Added support for disk init types

[matt-deboer]

Adds the capability to specify whether disks are "eager_zeroed" or "thin" upon creation, maintaining the original default behavior of "eager_zeroed"

resource "vsphere_virtual_machine" "web" {
    name = "webserver-01"
    vcpu = 1
    memory = 512
    disk {
        datastore = "${var.vsphere_datastore}"
        template = "${var.vsphere_template}"
        size = "100"
        type = "thin"
    }
}

Provides a fix for #3578

[tkak]

@matt-deboer Thank you for the PR. I think type is better than init_type like google provider.

[matt-deboer]

@tkak sounds fine to me; updated.

[tkak]

@matt-deboer Thanks! LGTM 👍

[ryanl-ee]

Personally I would be very happy to see this merged! :)

[mixacha]

@tkak pinging for greater justice, it'd be great if this was merged as having disks created as thick by default is good but on highly oversubscribed envrionments thin is actually preferred.

[deasmi]

Is there a reason this hasn't been merged?

I'm using it successfully.

It makes a big difference for dev/test when fast turn around matters.

[mixacha]

Seems like this was overlooked? I'm using a custom build with these changes merged, works like a charm.

Only datastore clusters remain.

Ping @jen20 can we get this one merged?

[SkiBum1942]

Also built and tested. It works great! We'd love to have it merged.
pinging @phinze

[phinze]

We're still working on getting the ability to run acceptance tests on our side, but based on the feedback here it sounds like this code is working well. Thanks @matt-deboer!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.