provider/azurerm: added local network gateway resource #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aznashwan! This looks good - much easier to add resources now the base work is in! In order to keep Terraform in a state where it can be released, could you consider adding acceptance tests (in this style) and resource documentation (like this)? |
aznashwan
force-pushed
the
f-azure-localnets
branch
2 times, most recently
from
79f0581
to
5b1b6a1
Compare
| @@ -13,13 +13,18 @@ | |||
| <li<%= sidebar_current(/^docs-azurerm-resource/) %>> | |||
| <a href="#">Resources</a> | |||
| <ul class="nav nav-visible"> | |||
| <li<%= sidebar_current("docs-azure-resource-resource-group") %>> | |||
| <li<%= sidebar_current("docs-azurerm-resource-resource-group") %>> | |||
aznashwan
force-pushed
the
f-azure-localnets
branch
from
5b1b6a1
to
42e28f7
Compare
|
Hi @aznashwan! Thanks for adding and fixing up the tests. However, running the new local network gateway acceptance tests causes a panic: |
|
|
||
| // fetch the 'address_space_prefix'es: | ||
| prefixes := []string{} | ||
| for _, pref := range d.Get("addres_space").([]interface{}) { |
There was a problem hiding this comment.
This is likely causing the panic mentioned below. Should be address_space I think?
|
Hi @aznashwan! Thanks for your work on this. I've submitted a pull request back to your branch which makes the acceptance tests pass and matches the patterns established by the exemplar resources. If you could review the changes, verify them for yourself by running the tests, and update here that would be great! The diffs should give a good idea of what is needed for the other open resource PRs as well. Thanks! |
This diff represents the changes necessary to make local network gateway tests pass: - Parse the resource ID instead of relying on attributes - Remove unecessary logging (which is handled via the autorest wrapper) - Resource GUID is removed - if this is actually required for anything we may need to find a way to supress it during apply, as we get spurious diffs in plans otherwise. - Various typos fixed.
aznashwan
force-pushed
the
f-azure-localnets
branch
from
de99a23
to
008dc97
Compare
|
@jen20: thanks for the updates; they have been picked in here. |
|
Thanks @aznashwan! Happy New Year! |
jen20
added a commit
that referenced
this pull request
Dec 31, 2015
provider/azure: added local network gateway resource
jen20
changed the title
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.