Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for http/https endpoints that auto confirms SNS topic subscription. #4711

Merged
merged 6 commits into from
Feb 14, 2016

Commits on Jan 17, 2016

  1. Added support for http/https endpoints that auto confirms SNS topic s…

    …ubscription.
    
    http and https SNS topic subscription endpoints require confirmation to set a valid arn otherwise
    arn would be set to "pending confirmation". If the endpoints auto confirm then arn is set
    asynchronously but if we try to create another subscription with same parameters then api returns
    "pending subscription" as arn but does not create another a duplicate subscription. In order to
    solve this we should be fetching the subscription list for the topic and identify the subscription
    with same parameters i.e., protocol, topic_arn, endpoint and extract the subscription arn.
    
    Following changes were made to support the http/https endpoints that auto confirms
    
    1. Added 3 extra parameters i.e.,
       1. endpoint_auto_confirms -> boolean indicates if end points auto confirms
       2. max_fetch_retries -> number of times to fetch subscription list for the topic to get the subscription arn
       3. fetch_retry_delay -> delay b/w fetch subscription list call as the confirmation is done asynchronously.
    
      With these parameters help added support http and https protocol based endpoints that auto confirm.
    
    2. Update website doc appropriately
    Srikalyan Swayampakula committed Jan 17, 2016
    Configuration menu
    Copy the full SHA
    9d12594 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2016

  1. Forgot to add one last condition to ensure that non pending confirmat…

    …ion subscription is returned.
    Srikalyan Swayampakula committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    63d6d8d View commit details
    Browse the repository at this point in the history
  2. Found an issue with more testing aws api is responding with various of

    "pending confirmation" such as "PendingConfirmation", "Pending Confirmation" etc.
    Srikalyan Swayampakula committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    3d256dd View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2016

  1. Updated the documentation to include the defaults for the remaining f…

    …ields added in the PR
    
    and add the link to amazon describing the auto confirming subscription.
    Srikalyan Swayampakula committed Feb 11, 2016
    Configuration menu
    Copy the full SHA
    5f558c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2016

  1. Update code based on the review suggestions.

    1. Used resource.Retry instead of custom solution
    2. Removed unnecessary variables and added required variable to resource.Retry.
    Srikalyan Swayampakula committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    f21dc99 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2016

  1. Made the necessary changes to ensure the variable name represents rig…

    …ht value.
    Srikalyan Swayampakula committed Feb 13, 2016
    Configuration menu
    Copy the full SHA
    345dbce View commit details
    Browse the repository at this point in the history