Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/azurerm: add cdn profile #4740

Merged
merged 1 commit into from
Jan 19, 2016
Merged

provider/azurerm: add cdn profile #4740

merged 1 commit into from
Jan 19, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jan 19, 2016

This will Scaffold the Azure RM CDN Profile

  • Schema
  • CRUD
  • Acceptance Tests
  • Documentation
make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=AzureRMCdnProfile' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=AzureRMCdnProfile -timeout 120m
=== RUN   TestResourceAzureRMCdnProfileSKU_validation
--- PASS: TestResourceAzureRMCdnProfileSKU_validation (0.00s)
=== RUN   TestAccAzureRMCdnProfile_basic
--- PASS: TestAccAzureRMCdnProfile_basic (302.15s)
=== RUN   TestAccAzureRMCdnProfile_withTags
--- PASS: TestAccAzureRMCdnProfile_withTags (383.56s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    685.

jen20
jen20 reviewed Jan 19, 2016
View reviewed changes
builtin/providers/azurerm/resource_arm_availability_set_test.go
@@ -119,7 +119,7 @@ func testCheckAzureRMAvailabilitySetExists(name string) resource.TestCheckFunc {
}

func testCheckAzureRMAvailabilitySetDestroy(s *terraform.State) error {
conn := testAccProvider.Meta().(*ArmClient).vnetClient
conn := testAccProvider.Meta().(*ArmClient).availSetClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this one come about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d'oh!

@jen20
Copy link
Contributor

jen20 commented Jan 19, 2016

LGTM - couple of minor questions/observations inline but nothing that blocks us merging here. Thanks @stack72!

jen20 added a commit that referenced this pull request Jan 19, 2016
@jen20
Merge pull request #4740 from stack72/azurerm-cdn-profile
44700f7 
provider/azurerm: add cdn profile
@jen20 jen20 merged commit 44700f7 into hashicorp:master Jan 19, 2016
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/azurerm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stack72 @jen20