aws: undeprecate min_elb_capacity; restore min capacity waiting #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // | ||
| // If "wait_for_elb_capacity" is specified, will also wait for that number of | ||
| // instances to show up InService in all attached ELBs. See "Waiting for | ||
| // Capacity" in docs for more discussion of the feature. |
There was a problem hiding this comment.
This comment needs to be updated, will follow up w/ that.
phinze
force-pushed
the
phinze/aws-min-elb-cap-regression
branch
2 times, most recently
from
4d572a4
to
5348932
Compare
It was a mistake to switched fully to `==` when activating waiting for capacity on updates in #3947. Users that didn't set `min_elb_capacity == desired_capacity` and instead treated it as an actual "minimum" would see timeouts for every create, since their target numbers would never be reached exactly. Here, we fix that regression by restoring the minimum waiting behavior during creates. In order to preserve all the stated behavior, I had to split out different criteria for create and update, criteria which are now exhaustively unit tested. The set of fields that affect capacity waiting behavior has become a bit of a mess. Next major release I'd like to rework all of these into a more consistently named block of config. For now, just getting the behavior correct and documented. (Also removes all the fixed names from the ASG tests as I was hitting collision issues running them over here.) Fixes #4792
phinze
force-pushed
the
phinze/aws-min-elb-cap-regression
branch
from
5348932
to
c70eab6
Compare
|
Alright all doc'd and comment'd and such. Good for review. |
|
I approve 👍 |
phinze
added a commit
that referenced
this pull request
Jan 27, 2016
…sion aws: undeprecate min_elb_capacity; restore min capacity waiting
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a mistake to switched fully to
==when activating waiting forcapacity on updates in #3947. Users that didn't set
min_elb_capacity == desired_capacityand instead treated it as an actual "minimum" wouldsee timeouts for every create, since their target numbers would never be
reached exactly.
Here, we fix that regression by restoring the minimum waiting behavior
during creates.
In order to preserve all the stated behavior, I had to split out
different criteria for create and update, criteria which are now
exhaustively unit tested.
The set of fields that affect capacity waiting behavior has become a bit
of a mess. Next major release I'd like to rework all of these into a
more consistently named block of config. For now, just getting the
behavior correct and documented.
Fixes #4792