-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up deps #5248
Fix up deps #5248
Conversation
Done with: ```console $ godep restore -v $ rm -rf Godep vendor/ $ godep save ./... ``` Spot checked, but things look legit. I don't (yet) know how to build terraform though.
Oh hey thanks @freeformz! Reviewing now. |
Hm looks like everything builds but google - looking into it. |
This release contains the Subnetwork stuff
@phinze |
That may have been me, sorry... |
This LGTM though now the build is green. |
We can (or at least should) be able to remove a bunch of the |
Does that depend on having a specific version of Godep? If so we might want to test for that in the Makefile also |
@jen20 yes >= v54 I'd be happy to add a check as well. |
Cool - I had reached the same update-google conclusion locally. Will await the Makefile tweaks and merge. I have a WIP here that adds dependency mgmt docs and moves us to just require Go1.6 so we can drop the env vars everywhere. I'll rebase that and get it pushed up after this lands. |
Actually just going to merge this as-is and we can circle back w/ Makefile improvements. Thanks so much for your help on this, @freeformz! 💟 |
@phinze Sorry it was so much of a pita in the first place. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Done with:
Spot checked, but things look legit. I don't (yet) know how to build
terraform though.
See also tools/godep#415 and tools/godep#416