Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up deps #5248

Merged
merged 2 commits into from
Feb 22, 2016
Merged

Fix up deps #5248

merged 2 commits into from
Feb 22, 2016

Conversation

freeformz
Copy link
Contributor

Done with:

$ godep restore -v
$ rm -rf Godep vendor/
$ godep save ./...

Spot checked, but things look legit. I don't (yet) know how to build
terraform though.

See also tools/godep#415 and tools/godep#416

Done with:

```console
$ godep restore -v
$ rm -rf Godep vendor/
$ godep save ./...
```

Spot checked, but things look legit. I don't (yet) know how to build
terraform though.
@phinze
Copy link
Contributor

phinze commented Feb 22, 2016

Oh hey thanks @freeformz! Reviewing now.

@phinze
Copy link
Contributor

phinze commented Feb 22, 2016

Hm looks like everything builds but google - looking into it.

@jen20 jen20 added enhancement build Auto-pinning labels Feb 22, 2016
This release contains the Subnetwork stuff
@freeformz
Copy link
Contributor Author

@phinze godep update google.golang.org/api/... committed seems to have fixed the problem. I assume someone was using a more recent local copy of google.golang.org/api/storage/v1

@jen20
Copy link
Contributor

jen20 commented Feb 22, 2016

That may have been me, sorry...

@jen20
Copy link
Contributor

jen20 commented Feb 22, 2016

This LGTM though now the build is green.

@freeformz
Copy link
Contributor Author

We can (or at least should) be able to remove a bunch of the go list | grep stuff in the Makefiles. Should add another commit to clean those up?

@jen20
Copy link
Contributor

jen20 commented Feb 22, 2016

Does that depend on having a specific version of Godep? If so we might want to test for that in the Makefile also

@freeformz
Copy link
Contributor Author

@jen20 yes >= v54 I'd be happy to add a check as well.

@phinze
Copy link
Contributor

phinze commented Feb 22, 2016

Cool - I had reached the same update-google conclusion locally. Will await the Makefile tweaks and merge.

I have a WIP here that adds dependency mgmt docs and moves us to just require Go1.6 so we can drop the env vars everywhere. I'll rebase that and get it pushed up after this lands.

@phinze
Copy link
Contributor

phinze commented Feb 22, 2016

Actually just going to merge this as-is and we can circle back w/ Makefile improvements.

Thanks so much for your help on this, @freeformz! 💟

phinze added a commit that referenced this pull request Feb 22, 2016
@phinze phinze merged commit b9cbbe8 into hashicorp:master Feb 22, 2016
@freeformz
Copy link
Contributor Author

@phinze Sorry it was so much of a pita in the first place.

@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants