Fix issue 518 #547
Merged
Fix issue 518 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's two commits in the PR. Did you see 82e4bab "command/init: test for issue 518"? |
| @@ -100,3 +100,45 @@ func TestInit_noArgs(t *testing.T) { | |||
| t.Fatalf("bad: \n%s", ui.OutputWriter.String()) | |||
| } | |||
| } | |||
|
|
|||
| // https://github.com/hashicorp/terraform/issues/518 | |||
| func TestIssue518(t *testing.T) { | |||
There was a problem hiding this comment.
Let's name this something more semantic like "TestInit_dstInSrc". We can still link to the issue, but it's useful to have semantic names for these types of things (imagine if GitHub is down for example)
|
@ceh weird. I definitely didn't see that yesterday 😄. I made one small comment around test naming, but otherwise 👍 |
|
This is fine 😄 |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't walk the destination path when it is a subdirectory of the source.
Fixes issue 518.