provider/aws: Fix all pointer RetryError returns #5538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also refs #5537. |
All of these RetryErrors were meant to fail right away, but instead caused retry looping because the typecheck in the implementation of `resource.Retry()` only catches the value type, and not the pointer type. Refs #5537
phinze
force-pushed
the
phinze/retryerror-pointers-are-evil
branch
from
e637848
to
de65694
Compare
phinze
added a commit
that referenced
this pull request
Mar 9, 2016
…e-evil provider/aws: Fix all pointer RetryError returns
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these RetryErrors were meant to fail right away, but instead
caused retry looping because the typecheck in the implementation of
resource.Retry()only catches the value type, and not the pointertype.
Refs #5537