Pulling out the hardcoded test user in the Github provider for #5729

[JacobASeverson]

From now on to run the acceptance tests a GITHUB_TEST_USER environment variable will have to be set with a valid Github user.

[jen20]

Hi @JacobASeverson! Thanks for the pull request - tentatively this looks good, but can you explain the rationale behind this change? Thanks!

[JacobASeverson]

Howdy! Sure - this is in response to what we discussed after the Github provider got merged per #5194. For the Github's acceptance tests I had hardcoded a user (TerraformDummyUser). While it is a dummy account and fine if other people run tests with it, we figured it would be better to provide a test user through an environment variable instead.

[jen20]

Ah yes I see the discussion now, that makes sense. Do we need to replace our usage of @TerraformDummyUser in the nightly tests, or is it something you are happy for us to continue using?

[JacobASeverson]

Nope, you can go ahead and keep using that account.

[jen20]

Thanks - I'll update the nightly acceptance test scripts now.

[JacobASeverson]

Cool, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.