Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: codecommit set default_branch only if defined #5904

Merged
merged 3 commits into from
Mar 30, 2016
Merged

AWS: codecommit set default_branch only if defined #5904

merged 3 commits into from
Mar 30, 2016

Commits on Mar 30, 2016

  1. provider/aws: codecommit set default_branch only if defined 

    Do not try to update or reaad the AWS codecommit repository default branch if
the resource definition is not set it or is an empty string.

Fixes hashicorp#5641
    @keymon
    keymon committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    1afd3a5 View commit details
    Browse the repository at this point in the history

  2. provider/aws: codecommit check default_branch before update 

    In AWS codecommit the default branch must have a value unless there are
no branches created, in which case it is not possible to set it to any value.

We query the existing branches and do not update the default branch
if there are none defined remotely.

This solves the issue of the initial creation of the repository with a
resource with `default_branch` defined.
    @keymon
    keymon committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    0c49b17 View commit details
    Browse the repository at this point in the history

  3. provider/aws: Add tests for default_branch in new codecommit repos 

    The provider should, when working on a new repository without branches:
 * Able to create a new repository even with default_branch defined.
 * Able to create a new repository without default_branch, and do not fail
   if default_branch is defined.
    @keymon
    keymon committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    29c9b84 View commit details
    Browse the repository at this point in the history