provider/postgresql: Add support for 'sslmode' options present in lib/pq

[xsellier]

• Update postgresql provider's documentation
• Enforce default value to 'require' for sslmode

[xsellier]

Compiled and tested locally, it works like a charm 🎱

[apparentlymart]

Normally we separate words with underscores, so I'd expect this to be ssl_mode.

However, we do make exceptions for things that are expected to be familiar to users of the service a provider is interacting with. So we could leave it as sslmode if that's how it's named in some visible part of the Postgres "UI", which I think it might be here because it seems like connStr is something like a DSN that you'd specify when configuring a client. Is that right?

[xsellier]

You are right 👍

According to this documentation, it is defined as sslmode.
By using connStr, it looks like postgresql://localhost:2345/postgres?sslmode=require
By using lib pq library, it looks like db, err := sql.Open("postgres", "user=postgres dbname=postgres sslmode=require")

But I'll rename it for ssl_mode if you prefer (I have no preference).

[xsellier]

So, should line rename it for ssl_mode

[apparentlymart]

I think my gut feeling is that it's better for it to be ssl_mode to match with the style used elsewhere in Terraform. That way users won't need to refer to the docs to remember what style is used for this attribute.

(Sorry for the delay in answering.)

[xsellier]

Thank you for your answer !
I've just amended/pushed the modification.

P.S:
Franckly, this delay is acceptable :)

[apparentlymart]

Thanks for this, @xsellier... it looks after a quick pass! I don't have spare cycles to test and merge this right now, but I'm going to assign it to myself to remind me to take a look at it soon.

[apparentlymart]

Thanks again @xsellier, and sorry for the delay on reviewing and merging this.

After familiarizing myself with the available sslmode options in the documentation I pushed a follow-up commit 220d73f to make prefer the default for now, since it seems safest to not unilaterally change the behavior people were seeing in earlier versions, and our usual policy is to keep as close as possible to the behavior of the underlying system to reduce surprises.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.