Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: CloudFront post-merge review updates #6196

Merged
merged 6 commits into from
Apr 19, 2016
Merged

provider/aws: CloudFront post-merge review updates #6196

merged 6 commits into from
Apr 19, 2016

Commits on Apr 19, 2016

  1. provider/aws: Fix hashing on CloudFront certificate parameters 

    Adding necessary type assertion to values on the viewer_certificate hash
function to ensure that certain fields are indeed not zero string
values, versus simply zero interface{} values (aka nil, as is such for a
map[string]interface{}).
    Chris Marchesi committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    f8dbda6 View commit details
    Browse the repository at this point in the history

  2. provider/aws: CloudFront complex structure error handling 

    Handle errors better on calls to d.Set() in the
aws_cloudfront_distribution, namely in flattenDistributionConfig(). Also
caught a bug in the setting of the origin attribute, was incorrectly
attempting to set origins.
    Chris Marchesi committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    ed1fa33 View commit details
    Browse the repository at this point in the history

  3. provider/aws: Pass pointers to set CloudFront primitives 

    Change a few d.Set() for primitives in aws_cloudfront_distribution and
aws_cloudfront_origin_access_identity to use the pointer versus a
dereference.
    Chris Marchesi committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    5648bdd View commit details
    Browse the repository at this point in the history

  4. docs: Fix CloudFront examples formatting 

    Ran each example thru terraform fmt to fix indentation.
    Chris Marchesi committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    4a3fd13 View commit details
    Browse the repository at this point in the history

  5. provider/aws: Remove delete retention on CloudFront tests 

    To play better with Travis and not bloat the test account with disabled
distributions.

Disable-only functionality has been retained - one can enable it with
the TF_TEST_CLOUDFRONT_RETAIN environment variable.
    Chris Marchesi committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    183948f View commit details
    Browse the repository at this point in the history

  6. provider/aws: CloudFront delete waiter error handling 

    The call to resourceAwsCloudFrontDistributionWaitUntilDeployed() on
deletion of CloudFront distributions was not trapping error messages,
causing issues with waiter failure.
    Chris Marchesi committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    1a518d9 View commit details
    Browse the repository at this point in the history