Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes-#6198-vsphere-provider-improve-documentation #6200

Conversation

tommymalmqvist
Copy link
Contributor

@tommymalmqvist tommymalmqvist commented Apr 16, 2016

There is some confusion about using the resource_pool arument to the resource definition. This will add a more complete example.

issue 6198

#6198

domain = "${var.vsphere_domain}"
datacenter = "${var.vsphere_datacenter}"
cluster = "${var.vsphere_cluster}"
resource_pool = "${var.vsphere_cluster}/Resources/${var.vsphere_resource_pool}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME!! How about some english describing how this works?? How about when there is not a cluster? Any other use cases?

@chrislovecnm
Copy link
Contributor

@tommymalmqvist any comments on my nit picks?

@tommymalmqvist
Copy link
Contributor Author

tommymalmqvist commented Apr 24, 2016

hey @chrislovecnm, I have moved the info. Check and see what you think. 👍

@tommymalmqvist tommymalmqvist force-pushed the fixes-6198-improve-documentation-vpshere branch from e0fe2df to 0108ef7 Compare April 24, 2016 10:32
@chrislovecnm
Copy link
Contributor

chrislovecnm commented Apr 24, 2016

Thanks @tommymalmqvist!

@stack72 @jen20 LGTM

@stack72 stack72 merged commit 243e5c8 into hashicorp:master Apr 24, 2016
@chrislovecnm
Copy link
Contributor

@stack72 thanks - but what u doin working on a Sunday :P Animal!!

terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
terraformbot pushed a commit that referenced this pull request Apr 25, 2016
[origin/master] fixes-#6198-vsphere-provider-improve-documentation (#6200)
243e5c8
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants