Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add name_prefix to more resources #6227

Closed
wants to merge 1 commit into from
Closed

[WIP] Add name_prefix to more resources #6227

wants to merge 1 commit into from

Conversation

joshuaspence
Copy link
Contributor

Closes #6099. I need to extend this change to other AWS resources, but I wanted to request some additional feedback as I am a new contributor to Terraform.

@jen20
Copy link
Contributor

jen20 commented Apr 18, 2016

Hi @joshuaspence! It looks like there is quite a lot of whitespace diff in this commit - is there a reason for that? Apart from that and the build errors currently reported by Travis (which look potentially like a missing import) this looks like positive progress! Thanks for opening a PR!

@joshuaspence
Copy link
Contributor Author

I ran make fmt and it touched a lot of files in the vendor/ directory... is this expected?

Closes #6099. I need to extend this change to other AWS resources, but I wanted to request some additional feedback as I am a new contributor to Terraform.
@jen20
Copy link
Contributor

jen20 commented May 3, 2016

@joshuaspence yes sadly, make fmt has not been correctly updated for vendoring yet. Is this work now considered complete (modulo build errors)?

@joshuaspence
Copy link
Contributor Author

I'm going to split this up into smaller PRs.

@joshuaspence joshuaspence deleted the name_prefix branch April 2, 2017 03:14
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support name prefix everywhere
2 participants