Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/fastly: Update Gzip handling with new go-fastly #6334

Merged
merged 2 commits into from
Apr 27, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Apr 25, 2016

sethvargo/go-fastly now handles the special case of ContentTypes and Extensions, regarding omitempty, because the Fastly API expects empty values if there are no content types or extensions...

This PR updates the vendored go-fastly and updates the code to remove the blemish.

$ make testacc TEST=./builtin/providers/fastly TESTARGS="-run=TestAccFastlyServiceV1_gzips_basic"
==> Checking that code complies with gofmt requirements...
/Users/clint/Projects/Go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/fastly -v -run=TestAccFastlyServiceV1_gzips_basic -timeout 120m
=== RUN   TestAccFastlyServiceV1_gzips_basic
--- PASS: TestAccFastlyServiceV1_gzips_basic (26.15s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/fastly 26.163s

@phinze
Copy link
Contributor

phinze commented Apr 27, 2016

LGTM

@catsby catsby merged commit 813f2ca into master Apr 27, 2016
@catsby catsby deleted the f-fastly-gzips-update branch April 27, 2016 15:46
jen20 added a commit that referenced this pull request Apr 27, 2016
[origin/master] provider/fastly: Update Gzip handling with new go-fastly (#6334)
813f2ca
xsellier pushed a commit to xsellier/terraform that referenced this pull request May 17, 2016
)

* provider/fastly: Bump to latest go-fastly

* provider/fastly: Update Gzip handling with new go-fastly
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants