[AWS] added support for multiple subnet associations to aws_network_acl

[zhukau]

No description provided.

[mitchellh]

Thanks! This has backwards compatibility... issues. I think we need to support both (in a mutually exclusive state) for the time being, and then do migrations in the future when we can support that.

[zhukau]

Do you mean that one to one relationship between Network ACL and Subnet went to public in v0.3.5? But it is incorrect implementation of NetworkACL AWS API (it expects an AssociationSet) and should be considered as a bug.

[phinze]

Do you mean that one to one relationship between Network ACL and Subnet went to public in v0.3.5? But it is incorrect implementation of NetworkACL AWS API (it expects an AssociationSet) and should be considered as a bug.

Agreed that it's basically a bug, but if we just remove the subnet_id field we'll blow up for anybody using it, which is not the best experience. If we support both for a spell we can deprecate the field and message about transition to the new, proper config.

Does that sound reasonable? Or are you saying that it actually was always blowing up with the old code?

[phinze]

~2 months of silence on the wire. Going to close this unless/until we hear back. 👌

[catsby]

FWIW I added support for one to many ACLs to Subnets in #1931

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.