provider/aws: Fix issue in upgrading AutoScaling Policy #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice fix - LGTM! I presume we need to put this in the release notes? |
|
@stack72 we'll add it to the release notes yeah... unfortunately it's "deprecated so you have to use this new thing now" instead of "hey you should use this new thing eventually" |
|
LGTM! |
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
* provider/aws: Fix issue in upgrading AutoScaling Policy min_adjustment_steps - Update depreciation message on min_adjustment_step
cristicalin
pushed a commit
to cristicalin/terraform
that referenced
this pull request
May 24, 2016
* provider/aws: Fix issue in upgrading AutoScaling Policy min_adjustment_steps - Update depreciation message on min_adjustment_step
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced with the addition of
min_adjustment_magnitudeand #4277 deprecation ofmin_adjustment_step. The upgrade path of swapping one for the other results in a reoccurring plan due to how we were handling zero values withGetOk(explained #6408 (comment)).This PR addresses the issue by setting
min_adjustment_stepto0ifmin_adjustment_magnitudeis found. The upgrade plan should be silent now; usingmin_adjustment_stepstill results in the depreciation warning,min_adjustment_magnitudecorrects the plan and returns no diffs.Unfortunately the API will set the
MinAdjustmentMagnitudeandMinAdjustmentStepto be equal, so settingMinAdjustmentStepwill result in aMinAdjustmentMagnitudevalue. Users will need to make this config swap, but with this PR the plan will be silent afterwards.Fixes #6408