Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption should be set to nil when snapshot_id is used for EBS device in AWS launch config #6452

Closed
wants to merge 1 commit into from

Conversation

sarguru
Copy link
Contributor

@sarguru sarguru commented May 3, 2016

Encryption should be set to nil when snapshot_id is used for EBS device in AWS launch config and not false. Fixes #5360. This was actually #6428 but closed it because of an error on my side.

@stack72
Copy link
Contributor

stack72 commented May 3, 2016

Hi @sarguru

Thanks so much for the PR here - have you have a chance to run the tests here on this?

P.

@sarguru
Copy link
Contributor Author

sarguru commented May 3, 2016

Hi @stack72 I tested the functionality by running make plugin-dev , which worked fine. For the go tests I just checked https://travis-ci.org/hashicorp/terraform/builds/127515189 here.

@jen20
Copy link
Contributor

jen20 commented May 3, 2016

Hi @sarguru! I rebased this onto master before merging - it landed as a5825f9. Thanks for your work!

@sarguru
Copy link
Contributor Author

sarguru commented May 3, 2016

Thanks for getting this in quickly @jen20 <3

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs_block_device parameter 'encrypted' evaluated as 'true' even when not set
3 participants