provider/aws: aws_ami_description - data source edition (now aws_ami) #6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancluever
changed the title
vancluever
force-pushed
the
paybyphone_aws_ami_description_data_source
branch
2 times, most recently
from
5301288
to
b90f999
Compare
vancluever
changed the title
|
All done, just needed to fix the docs :) |
vancluever
pushed a commit
to paybyphone/terraform
that referenced
this pull request
May 28, 2016
During accpeptance tests of some of the first data sources (see hashicorp#6881 and hashicorp#6911), "unknown resource type" errors were coming up. It looks like DataSourcesMap was not being taken into account in *schema.Provider.Apply(), causing this error. Also, added a skip in *schema.Resource.Apply() if *schema.Resource.Destroy() is not defined, as data sources do not define this, fixing the first error resulted in a nil pointer dereference.
vancluever
pushed a commit
to paybyphone/terraform
that referenced
this pull request
May 28, 2016
During accpeptance tests of some of the first data sources (see hashicorp#6881 and hashicorp#6911), "unknown resource type" errors were coming up. It looks like DataSourcesMap was not being taken into account in *schema.Provider.Apply(), causing this error. Also, added a skip in *schema.Resource.Apply() if *schema.Resource.Destroy() is not defined, as data sources do not define this, fixing the first error resulted in a nil pointer dereference.
vancluever
pushed a commit
to paybyphone/terraform
that referenced
this pull request
May 29, 2016
During accpeptance tests of some of the first data sources (see hashicorp#6881 and hashicorp#6911), "unknown resource type" errors have been coming up. Traced it down to the ResourceCountTransformer, which transforms destroy nodes to a graphNodeExpandedResourceDestroy node. This node's EvalTree() was still indiscriminately using EvalApply for all resource types, versus EvalReadDataApply. This accounts for both cases via EvalIf.
This data source allows one to look up the most recent AMI for a specific set of parameters, much like aws ec2 describe-images in the AWS CLI. Basically a refresh of hashicorp#4396, in data source form.
vancluever
force-pushed
the
paybyphone_aws_ami_description_data_source
branch
from
b90f999
to
9ac7fb0
Compare
vancluever
changed the title
|
I've renamed this to |
Great work @vancluever! |
|
Woohoo! Thanks @jen20! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #4396 in data source form. See that issue/PR for details.
Incidentally, porting this was very easy, with one small testing caveat - to test the "resource" properly, I had to prefix the name with
datato ensure that it could be looked up in the state. This may just be semantics we have to live with, or could be the basis for a quality of life update.I also ran into the same bug that @jen20 is running into on #6881, for which I have a fix incoming shortly.