provider/aws: Retry association of IAM Role & instance profile #7938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Nice one @radeksimko :) |
|
❤️ |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #2660 which reappears from time to time.
It is obviously difficult to reproduce this issue as it's caused by IAM eventual consistency, but here's a snippet from a debug log from today (0.7.0): https://gist.github.com/radeksimko/1e0533e6c998c55fbb69da9851fcb779
and here's the config used: https://gist.github.com/radeksimko/3891ad1e3b3d295238b04a55dd869c09
Side effects
Theoretically this may cause small delays for users who are trying to launch an EC2 instance w/ IAM instance profile that actually has no IAM roles assigned to it. Users that use Terraform to manage instance profiles should never run into such situations though as
aws_iam_instance_profile.rolesis required field.