config: fix for #786 - better error reporting #818
Conversation
| @@ -105,6 +106,13 @@ func (c *Config) Discover() error { | |||
| } | |||
| } | |||
|
|
|||
| if len(c.Providers) == 0 { | |||
| return errors.New("no providers found") | |||
There was a problem hiding this comment.
Thanks! Just a cosmetic note about the style.... I think it's more idiomatic (and inline with the code style used in TF) to write this as return fmt.Errorf("no providers found")
There was a problem hiding this comment.
You're right. I saw some errors.New calls, but fmt.Errorf is clearly the dominant style.
There was a problem hiding this comment.
Yeah, your right about that... I also see some errors.New in the code (now that I'm looking for it 😉), so apparently it doesn't matter that much and isn't used consistently...
Thanks!
Following dominant style in TF, as suggested by svanharmelen.
|
Thanks! This is one way to fix it, but I think this should actually happen later during config validation. It should be an error if we can't find any provider (not just have 0) that we intend to use. Let me see if I can work with #786 to make that happen. |
|
Yeah, as I suspected the root cause was actually pretty deep in TF. I caught that. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
As discussed in #786 , terraform crashes when no providers could be found. I can think of no good reason to run terraform without any provider or provisioner, so I've added extra error reporting.