provider/aws: Add aws_alb_listener resource #8268
Conversation
| } | ||
|
|
||
| resource "aws_alb_listener" "front_end" { | ||
| load_balancer_arn = "${aws_alb.front_end.id}" |
There was a problem hiding this comment.
I realize that in our case, the ID and the ARN of the ALB are the same, but what do you think about exposing the ARN on the ALB resource, and then referencing that here?
I think that, while it's kind of a minor detail for us, it makes more sense to a user use a config like this:
load_balancer_arn = "${aws_alb.front_end.arn}"
over this
load_balancer_arn = "${aws_alb.front_end.id}"
There was a problem hiding this comment.
The same would be true for TargetGroup below
There was a problem hiding this comment.
This seems fairly reasonable, I'll add it shortly.
|
I think for a UX perspective we should add and export the ARNs of this and |
jen20
force-pushed
the
f-aws-application-lb-listener
branch
from
5f095a6 to
00e4ef6
Compare
This commit adds the `aws_alb_listener` resource and associated acceptance tests and documentation.
This commit adds an `arn` field to `aws_alb` and `aws_alb_target_group` resources, in order to present a more coherant user experience to people using resource variables in fields suffixed "arn".
jen20
force-pushed
the
f-aws-application-lb-listener
branch
from
00e4ef6 to
e38d41b
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This commit adds the
aws_alb_listenerresource and associated acceptance tests and documentation.This is part of a series of pull requests in order to implement #8137.