-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-1275] Support for AWS access via IAMs AssumeRole functionality #8506
Conversation
This commit enables terraform to utilise the assume role functionality of sts to execute commands with different privileges than the API keys specified. Signed-off-by: Ian Duffy <ian@ianduffy.ie>
Hi @imduffy15! Thanks for submitting a pull request here. I need to make some modifications to this in order to allow for some of the other behaviour we need to support, but I'm going to base them off your work and merge my in-progress stuff into this. I'll probably open a new pull request once this is done for a combined review, so will leave this open for now and reference it then. |
Cool! Thanks James. On Friday 2 September 2016, James Nugent notifications@github.com wrote:
|
Hi @imduffy15! Did you manage to verify the version from this PR as working correctly? |
Yes. I tested with the following:
The role was successfully created on both accounts. |
Thanks @imduffy15 - how were you supplying credentials to Terraform in order to assume the role on this run? |
I was using ~/.aws/credentials with the profile [default] |
Hi @imduffy15! Thanks for this, I've changed it round a bit and opened #8638 - I'd be appreciative of any comments you have there! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This commit enables terraform to utilise the assume role functionality
of sts to execute commands with different privileges than the API
keys specified.
Feedback very much so welcome, this was thrown together as a quick hack.
Signed-off-by: Ian Duffy ian@ianduffy.ie