Allow count in data sources #8635
Conversation
|
Looks really great! A couple things:
|
jbardin
force-pushed
the
jbardin/GH-8527
branch
2 times, most recently
from
36c91b4
to
387ae8a
Compare
|
@mitchellh Can you give me an example of what you mean by that first part? I couldn't come up with a good test for apply that didn't just repeat the plan. It's probably the same issue I had with assigning "${count.index}" -- I couldn't figure out how to expose them correctly in the tests (the data sources show up differently in the state than regular resources). |
|
@mitchellh I'm not so sure there is a distinct apply test here because of the refresh at plan to make the values known? |
|
You're probably right with refresh and I can add a count.index test later. |
Data sources should be able to support counts like a resource. We need to remove "count" when we load the config because the key doesn't exist in the schema, and the resource won't validate.
|
Also fixes #7919 (and probably some others). |
jen20
force-pushed
the
jbardin/GH-8527
branch
from
387ae8a
to
b236f86
Compare
This adds a unit test to the test provider that verifies count.index behaves correctly. Although not ideal this is hard to implement as a context test without changing around the (non helper/schema) implementation of the x_data_source.
jen20
force-pushed
the
jbardin/GH-8527
branch
from
b236f86
to
fb150ef
Compare
|
I've added a test of count.index, but to avoid circular dependencies or large modifications to the null providers used in context tests it is implemented as a unit test in the |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Count worked in data sources, but the resource validation would fail due to the extra "count" key in the raw config. Make sure the HCL loader removes count.
Fixes #8527