Vendored WAF #8785
Vendored WAF #8785
Conversation
|
Hi @optimisticanshul Can you add the vendored WAF as of the 1.4.7 release of the SDK? This means we are going to be following the same release as the other pieces of the SDK Thanks Paul |
radeksimko
added
the
waiting-response
|
Hi Paul sorry for stupid question but can you please elaborate what needs On 12-Sep-2016 15:31, "Paul Stack" notifications@github.com wrote:
|
|
Hi @optimisticanshul, I believe @stack72 was suggesting to upgrade the existing vendoring of the whole of the AWS SDK to 1.4.7, rather than just adding the WAF service package within the version we were already running. I'm not sure if there are some specific steps to deal with this for the AWS provider, but usually when upgrading packages we'd do something like this: We like to upgrade upstream libraries in whole so that we don't get any unexpected friction between the parts and so we can more easily reason about what version we're currently running compared to the upstream. |
|
Hi @optimisticanshul (and @apparentlymart) The command I run for a specific tag is as follows: If you can, please ensure the WAF vendor updates are of the same tag Paul |
|
@stack72 Updated ready for another review 👍 |
|
👍 |
…ull_window * upstream/master: (31 commits) core: Log local overrides as INFO rather than WARN provider/aws: Retry resourceAwsLaunchConfigurationCreate if instance profile hasn't propagated (hashicorp#8813) changing AWS_SECURITY_TOKEN to AWS_SESSION_TOKEN (hashicorp#8816) Update ses_receipt_rule_set.html.markdown Warn when plugins are locally overridden Fix a typo in the output command examples aws_instance doc: fix attachment resource name Vendored WAF (hashicorp#8785) update github.com/hashicorp/go-getter Update CHANGELOG.md provider/azurerm: Removing the diagnostics part of the test from the azurerm virtual machine unattended acceptance test Update CHANGELOG.md Update CHANGELOG.md provider/aws: Removal of test for changes as it forces a new resource provider/aws: Allow `aws_alb` to have the name auto-generated Update CHANGELOG.md Remove Unused Log From CodeCommit Trigger Test provider/aws: Support Policy DiffSuppression in `aws_kms_key` policy Update CHANGELOG.md provider/cloudstack: fix vpc renaming (hashicorp#8784) ...
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
@radeksimko As discussed in #8705 This PR vendor WAF of aws sdk.
I will close the #8705 once we complete all the checkpoints.