Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Change vpc_id to id in documentation #8981

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Sep 22, 2016

Fixes #8979

@stack72
Copy link
Contributor

stack72 commented Sep 22, 2016

LGTM!

@stack72 stack72 merged commit c5ce373 into master Sep 22, 2016
@stack72 stack72 deleted the doc-default-security-group-vpc-id branch September 22, 2016 07:53
@ghost
Copy link

ghost commented Sep 22, 2016

👎
you still have the same error a few lines down the documentation :)
line #73
vpc_id = "${aws_vpc.mainvpc.vpc_id}"

@stack72
Copy link
Contributor

stack72 commented Sep 22, 2016

Hi @kobymeir-reposify

Thank you for pointing out the error - I believe the fix was to fix the example that you pointed out in the original issue. I will fix this second one now

Paul

jen20 added a commit that referenced this pull request Sep 22, 2016
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation error on aws_default_security_group
2 participants