provider/aws: VPC ID, Port, Protocol and Name change on aws_alb_target_group will ForceNew resource #8989
Conversation
| func testAccChecALBTargetGroupRecreated(t *testing.T, | ||
| before, after *elbv2.TargetGroup) resource.TestCheckFunc { | ||
| return func(s *terraform.State) error { | ||
| if before.TargetGroupArn == after.TargetGroupArn { |
There was a problem hiding this comment.
This checks the pointers, not the values, so this will always pass given how we're construction the two group structs in testAccCheckAWSALBTargetGroupExists. If you compare the actual values, you find that only TestAccAWSALBTargetGroup_changeNameForceNew passes here because that's the only one that changes the name, thus changes the ARN (being a combo of region, account, and name). All the other tests fail when checking the values here, because the name hasn't changed, so the ARN hasn't changed, even though the resource was actually destroyed and recreated.
I think it's sufficient to check that the new values were expecting were set. In this situation we don't actually care if it has a new ARN, or that the VPC changed in a ForceNew operation, we just care that if someone changed the VPC, that the change actually happens.
| * `port` - (Required) The port on which targets receive traffic, unless overridden when registering a specific target. | ||
| * `protocol` - (Required) The protocol to use for routing traffic to the targets. | ||
| * `vpc_id` - (Required) The identifier of the VPC in which to create the target group. | ||
| * `name` - (Required) The name of the target group. Change forces new resource. |
There was a problem hiding this comment.
I'm not strictly opposed to this inclusion, but I'm not sure we make note of the ForceNew behavior in other resources, do we?
stack72
force-pushed
the
b-aws-alb-protocol-change-forcenew
branch
from
1058bf1
to
8edb43e
Compare
|
@catsby you are correct - I have updated all as requested :) |
aws_alb_target_group will ForceNew resource Fixes #8741 The modify-target-group doesn't allow changes to name, port, protocol or vpc_id - therefore, they should all be ForceNew: true ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALBTargetGroup_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/22 16:04:29 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALBTargetGroup_ -timeout 120m === RUN TestAccAWSALBTargetGroup_basic --- PASS: TestAccAWSALBTargetGroup_basic (50.66s) === RUN TestAccAWSALBTargetGroup_changeNameForceNew --- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (84.48s) === RUN TestAccAWSALBTargetGroup_changeProtocolForceNew --- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (95.89s) === RUN TestAccAWSALBTargetGroup_changePortForceNew --- PASS: TestAccAWSALBTargetGroup_changePortForceNew (85.77s) === RUN TestAccAWSALBTargetGroup_changeVpcForceNew --- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (85.00s) === RUN TestAccAWSALBTargetGroup_tags --- PASS: TestAccAWSALBTargetGroup_tags (88.11s) === RUN TestAccAWSALBTargetGroup_updateHealthCheck --- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (82.15s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 572.083s ```
stack72
force-pushed
the
b-aws-alb-protocol-change-forcenew
branch
from
8edb43e
to
9fbbc34
Compare
|
New acceptance test run: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #8741
The modify-target-group doesn't allow changes to name, port, protocol or
vpc_id - therefore, they should all be ForceNew: true