312 route 53 default record name

[catsby]

First pass at fixing #312.
This will allow AWS Route53 Records to simply specify a subdomain and not the fully qualified name:

Given a zone:

resource "aws_route53_zone" "main" {
  name = "example.com"
}

this change then supports the current:

resource "aws_route53_record" "www" {
  [...]
  name = "www.example.com"
  [...]
}

and shorter:

resource "aws_route53_record" "www" {
  [...]
  name = "www"
  [...]
}

both result in a Route53 record with name www.example.com.

[sethvargo]

Since you aren't using ok elsewhere, you can just boolean this:

if !strings.HasSuffix(recordName, zoneName) {
  // ...
}

[catsby]

done

[pearkes]

Nice, LGTM!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.