provider/aws: Convert Route 53 Zone resource to use awslabs/aws-sdk-go #971
Conversation
| @@ -104,6 +104,9 @@ func testAccCheckRoute53RecordExists(n string) resource.TestCheckFunc { | |||
| } | |||
|
|
|||
| const testAccRoute53RecordConfig = ` | |||
| provider "aws" { | |||
| region = "us-east-1" | |||
| } | |||
There was a problem hiding this comment.
The Record acceptance tests throw error(s) without this entry in the config now.
It's related I think to a default config entry that the setup isn't finding for awslabs/aws-sdk-go, but I'm not sure where.
2015/02/12 16:26:09 [DEBUG] aws_route53_zone.main: expanding to count = 1
2015/02/12 16:26:09 [INFO] Module root walking: aws_route53_zone.main (Graph node: aws_route53_zone.main)
2015/02/12 16:26:09 [DEBUG] aws_route53_zone.main: Executing Apply
2015/02/12 16:26:09 [DEBUG] Creating Route53 hosted zone: %!s(aws.StringValue=0x1191ca28)
2015/02/12 16:26:10 [ERROR] Error walking 'aws_route53_zone.main': 1 error(s) occurred:
* Credential should be scoped to a valid region, not 'us-west-2'.
There was a problem hiding this comment.
Worth noting that other acceptance tests assume us-west-2 in their selection of AMI IDs and the like. I've been meaning to enforce this at the top level in the acceptance test suite since I discovered it.
There was a problem hiding this comment.
For posterity: fixed in 700ce30 by hardcoding us-east-1, because v4 of Signing requires all global things (like Route 53) to use us-east-1.
|
Great work! LGTM. Interesting that aws-go has a built-in for |
…dk-go library. This commit updates the Route 53 Zone resource to use AWS Labs aws-sdk-go library instead of mitchellh/goamz. - hard code us-east-1 for Route53 region, since it's a global endpoint - add some units test for CleanZoneID
catsby
force-pushed
the
aws-go-route53
branch
from
67b2351
to
94e7723
Compare
|
LGTM. Merging it in. |
provider/aws: Convert Route 53 Zone resource to use awslabs/aws-sdk-go
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
🚧 This is a work in progress 🚧
This commit updates the Route 53 Zone resource to use AWS Labs aws-sdk-go
library instead of mitchellh/goamz.
This is meant as a spike to begin converting resources one by one to the new
library.
It's rough, I'll comment inline on things I wasn't sure on.