provider/aws: allow empty value for autoscaling schedule parameters #9941
Conversation
glasser
force-pushed
the
glasser/scheduled-action-empty
branch
from
b09a38e
to
6f62c21
Compare
|
Updated to resolve merge conflicts. |
Specifically, this allows you to create a schedule which only changes some of the group parameters without changing others, by setting the parameters you wish to remain empty to -1. This means you can adjust min or max size without affecting the desired capacity, for example. The ad hoc support for -1 isn't as nice as having real support for leaving values out (see hashicorp#5694) but it solves a real use case. Fixes hashicorp#5681.
glasser
force-pushed
the
glasser/scheduled-action-empty
branch
from
6f62c21
to
4c06b64
Compare
|
Updated to resolve merge conflicts, again. Would love to see this merged! |
|
Is there any movement on this PR? This would be immensely helpful :) |
|
+1'ing - This would be incredibly helpful in terms of operational overhead for us since we rely heavily on ASGs. Are there any concerns from Hashicorp's side w.r.t. this PR? |
|
+1 But maybe you should move this PR in the new provider: repo https://github.com/terraform-providers/terraform-provider-aws ? |
|
Hi @glasser, thanks for the contribution! Extremely sorry we didn't get to this sooner, and now have more to ask of you. If you wouldn't mind migrating this PR to the new provider repository and tag me, I'll be sure to review it as soon as I can. If you no longer wish to author this PR, I can migrate it for you as well. Closing for now though, thanks again! |
|
@grubernaut If you're inspired to migrate it, that would be great — I haven't had time to update our fork of Terraform (and our build system) to the new multi-repo world yet. |
|
Okay cool, I'll work on this tomorrow. Thanks for all the initial work on this @glasser! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Specifically, this allows you to create a schedule which only changes
some of the group parameters without changing others, by setting the
parameters you wish to remain empty to -1. This means you can adjust
min or max size without affecting the desired capacity, for example.
The ad hoc support for -1 isn't as nice as having real support for
leaving values out (see #5694) but it solves a real use case.
Fixes #5681.