-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Install Pages #12940
Docs Install Pages #12940
Conversation
However, beware of the following pitfalls: | ||
You must install Ruby 2.2 or newer to develop and build Vagrant. The | ||
specific Ruby version that you will need is documented in `vagrant.gemspec`, located in the repository on GitHub. It contains the most | ||
up-to-date requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes sound good but the new lines are a little wonky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change on the Ruby version referenced but looks great otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some style suggestions but otherwise 👍
Co-authored-by: Anthony <russo555@gmail.com>
in `vagrant.gemspec`, located in the repository on GitHub. | ||
It contains the most up-to-date requirements. | ||
|
||
~> **Note:** It is not recommended that you use the system Ruby. You need a Ruby version manager like RVM or chruby. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~> **Note:** It is not recommended that you use the system Ruby. You need a Ruby version manager like RVM or chruby. | |
~> **Note:** We do not recommended that you use the system Ruby. You need a Ruby version manager like RVM or chruby. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note can be discarded now. This is less of an issue anymore now that recent rubies are generally available via system packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. One note that should probably be dropped.
in `vagrant.gemspec`, located in the repository on GitHub. | ||
It contains the most up-to-date requirements. | ||
|
||
~> **Note:** It is not recommended that you use the system Ruby. You need a Ruby version manager like RVM or chruby. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note can be discarded now. This is less of an issue anymore now that recent rubies are generally available via system packages.
Co-authored-by: Anthony <russo555@gmail.com>
Hello @kaitlincart! 😊 This is a quick comment to let you know I've updated this PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
the `vagrant.gemspec` in the repository on GitHub, as it will contain the most | ||
up-to-date requirement. This guide will not discuss how to install and manage Ruby. | ||
However, beware of the following pitfalls: | ||
You must install Ruby 2.7 or newer to develop and build Vagrant. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently Vagrant needs Ruby between 3.0 - 3.2. This will keep changing, so this can probably be a bit more vague and continue to reference the vagrant.gemspec
to provide the most up to date info on Ruby version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Copy edits to the following pages: