Fix for #658 #711
Closed
Fix for #658 #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What? This really works? Bizarre. This fixes all JRuby 64-bit issues? |
|
Merged. Thanks! Can you install from git and give it a shot? |
|
This does fix the issue where VMBoxManage --version was failing the second time. But now I've found what appears to be another childprocess JRuby bug. Details here: I'm going to work jarib to resolve this. But I'm going to submit the sorry. |
|
The child process bug will be resolved in 0.3.1 as mentioned here: Would you like to upgrade to that version? |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #658 by moving the closing of subprocess streams to after the process has finished
Background:
#658
enkessler/childprocess#30