Fix guest bugs #7605

sethvargo · 2016-07-19T01:38:48Z

Fixes Shellescape rsync paths #7580 (shellescape rsync guest paths)
Fixes NFS mount fails when path has spaces on guest #7540 (shellescape nfs guest paths)
Fixes Vagrant > 1.8.1 uses /sbin/ifup with empty interface name #7539 (/sbin/ip returning empty ips)
Fixes Getting error '/sbin/ifdown: interface not configured' on vagrant up of trusty64 box #7537 (/sbin/ip returning empty ips)
Fixes Error setting hostname when setting up a centos-7.2 box #7533 (don't restart networking on hostname change)
Fixes Ubuntu short hostname is now set to full value of config.vm.hostname instead of first segment #7488 (use short hostname on ubuntu)
Fixes Problem with NFS Shared Folder Permissions on Mac OS X (El Capitan) #6360 (properly raise error on nfs mounts so retries take place)
Fixes No newline at the end of authorized_keys #7598 (ensure newline at end of authorized keys file)

Refs: https://lukas.zapletalovi.com/2011/12/setting-hostname-properly-in-fedora-and.html

Fedora should have been a child of redhat for awhile now...

Arch expects /24 for netmask, but users usually specify as a netmask block like 255.255.255.0. This automatically converts it.

This is already done via the rsync_installed capability.

Restarting networking causes Vagrant to disconnect and fail.

BSD-based guests do not support VirtualBox shared folders. This is a common source of confusion in Vagrant. This new error clearly explains that this is not a bug in Vagrant and provides instructions on how to disable them.

This allows users to have spaces or other special characters in destination paths on the guest.

sethvargo added 30 commits July 18, 2016 21:12

guests/funtoo: Behave like a gentoo guest

3eebff5

guests/arch: Search for FQDN hostname

10b12ce

guests/atomic: Search for FQDN hostname

bbcddb6

guests/bsd: Do not use -h to shutdown

5a372a9

guests/debian: Set hostname to short value

87d2b7f

Refs GH-7488

guests/fedora: Fix indentation on configure hostname

5777460

guests/freebsd: Check FQDN for hostname

ea9b28f

guests/gentoo: Use predictable network interface names

caafb93

guests/ubuntu: Use short hostname

4664930

Fixes GH-7488

guests/rhel: Switch to predicable network interface names

b621cc4

Fix failing tests

66cbe7b

guests/linux: Add shared cap for listing network interfaces

8f3b651

guests: Always search for FQDN without sudo

cf91bcf

guests/rhel: Use FQDN for hostname

336cb33

Refs: https://lukas.zapletalovi.com/2011/12/setting-hostname-properly-in-fedora-and.html

guests/fedora: Move as a child of redhat

084d62b

Fedora should have been a child of redhat for awhile now...

guests/arch: Ensure exit on error setting hostname

cf9a8e3

guests/arch: Add NFS capabilities

e69211a

guests/arch: Ensure exit on configure networks fail

9ea1310

guests/linux: reorg

627091d

guests/arch: compute netmask

ccc40eb

Arch expects /24 for netmask, but users usually specify as a netmask block like 255.255.255.0. This automatically converts it.

guests/atomic: Ensure error exit when setting hostname

0af02fc

guests/debian: Move NFS into same file

9134172

guests/debian: Exit on error when configuring hostname

7a7256b

guests/debian: Use set -e when configuring networks

76bab19

guests/debian: Do not check if rsync is installed before installing

cb2f3a6

This is already done via the rsync_installed capability.

guests/linux: Centralize public_key logic

4aaa600

guests/linux: Properly escape and retry vbox shared folder mounting

7e88266

guests/darwin: Exit on error setting hostname

619c7a5

guests/darwin: Shellescape guest path for rsync

d1a071d

guests/debian: Do not restart networking

c4a0a86

Restarting networking causes Vagrant to disconnect and fail.

sethvargo added 9 commits July 18, 2016 21:12

guests/freebsd: Escape guest path in rsync folders

72dcf61

guests/gentoo: Exit on hostname error

8fe47b7

guests/gentoo: Use shared cap for listing network interfaces

e2becda

guests/linux: Style update for choose_addressable_ip

1c0d0b8

folders/rsync: Shellescape guest paths

7f1947f

This allows users to have spaces or other special characters in destination paths on the guest.

guests/ubuntu: Use debians change_host_name functionality

1e0d7bb

guests/openbsd: Fix hostname setting

7868421

Fix tests

1849990

sethvargo merged commit 1277f19 into master Jul 19, 2016

sethvargo deleted the sethvargo/integ branch July 19, 2016 01:44

ghost locked and limited conversation to collaborators Apr 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix guest bugs #7605

Fix guest bugs #7605

sethvargo commented Jul 19, 2016 •

edited

Loading

Fix guest bugs #7605

Fix guest bugs #7605

Conversation

sethvargo commented Jul 19, 2016 • edited Loading

sethvargo commented Jul 19, 2016 •

edited

Loading