guests/linux: Update network interface sorting implementation #7866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always pull ordered ethernet devices to the head of the list. Ensure aliases are not included.
|
i can confirm this fixes #7458 for me |
sethvargo
approved these changes
Oct 8, 2016
Add failing networking interface list sorting test with example provided by hashicorp#7883. Update sorting logic to properly handle different types and differing array lengths. Fixes hashicorp#7883
This was referenced Oct 24, 2016
|
@mitchellh: Do you know a release date for 1.8.7 already? |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always pull ordered ethernet devices to the head of the list. Ensure
aliases are not included.
Fixes: #7858
Fixes: #7458
Fixes: #7876