Write a better error message when key not found

hashicorp · Jan 27, 2021 · cbd20bc · cbd20bc
1 parent 5e5c06a
commit cbd20bc
Show file tree

Hide file tree

Showing 7 changed files with 115 additions and 3 deletions.
diff --git a/.DS_Store b/.DS_Store
diff --git a/.idea/modules.xml b/.idea/modules.xml
diff --git a/.idea/vault-action.iml b/.idea/vault-action.iml
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/integrationTests/basic/integration.test.js b/integrationTests/basic/integration.test.js
@@ -123,6 +123,14 @@ describe('integration', () => {
             .mockReturnValueOnce(secrets);
     }
 
+    it('prints a nice error message when secret not found', async () => {
+        mockInput(`secret/data/test secret ;
+        secret/data/test secret | NAMED_SECRET ;
+        secret/data/notFound kehe | NO_SIR ;`);
+
+        expect(exportSecrets()).rejects.toEqual(Error(`Unable to retrieve result for "secret/data/notFound". Double check your Key.`));
+    })
+
     it('get simple secret', async () => {
         mockInput('secret/data/test secret');
 

diff --git a/src/secrets.js b/src/secrets.js
@@ -34,9 +34,17 @@ async function getSecrets(secretRequests, client) {
             body = responseCache.get(requestPath);
             cachedResponse = true;
         } else {
-            const result = await client.get(requestPath);
-            body = result.body;
-            responseCache.set(requestPath, body);
+            try {
+                const result = await client.get(requestPath);
+                body = result.body;
+                responseCache.set(requestPath, body);
+            } catch (error) {
+                const {response} = error;
+                if (response.statusCode === 404) {
+                    throw Error(`Unable to retrieve result for "${path}". Double check your Key.`)
+                }
+                throw error
+            }
         }
         if (!selector.match(/.*[\.].*/)) {
             selector = '"' + selector + '"'