-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): add support for github provided jwt auth #257
Conversation
- Update README - Switch to use `getIDToken` method for Github token retrieval - Bump `@actions/core` to 1.6.0 - Add `jwtGithubAudience` input - Remove unnecessary code
fix: get token via `@actions/core`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Left a couple of thoughts.
It would also be great if you could remove the changes to dist/index.js since we typically don't update that file until we do a release.
And it would be even better if this could be tested in the integrationTests, similar to the regular jwt auth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Thanks so much!
This PR add support for Github provided JWT
Example Usage
Example Github provided JWT
Example JWT Auth Config
Example JWT Role
Notice: Based on unreleased Github feature