Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print vault error message on authentication failure #409

Merged
merged 8 commits into from
Jan 23, 2023

Conversation

kevinschoonover
Copy link
Contributor

@kevinschoonover kevinschoonover commented Jan 16, 2023

image

similar to #276, but you dont need to enable debug logging

closes #273

also changes ncc to vercel/ncc

@austingebauer austingebauer self-requested a review January 17, 2023 16:29
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion. Otherwise, LGTM! Thanks for this.

src/auth.js Outdated Show resolved Hide resolved
kevinschoonover and others added 2 commits January 23, 2023 12:56
Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
@kevinschoonover
Copy link
Contributor Author

@austingebauer fixed the merge conflicts / comments so this should now be good to go

@austingebauer
Copy link
Contributor

Thanks, @kevinschoonover!

@austingebauer austingebauer merged commit 7318a98 into hashicorp:main Jan 23, 2023
@ps-jay
Copy link

ps-jay commented Jan 31, 2023

Thanks folks! Quality of life improved ☺️

TomNorth pushed a commit to TomNorth/vault-action that referenced this pull request Mar 25, 2023
Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Return more information on 400 error code
3 participants