Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development flow enhancements #430

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Development flow enhancements #430

merged 3 commits into from
Feb 28, 2023

Conversation

maxcoulombe
Copy link
Contributor

@maxcoulombe maxcoulombe commented Feb 27, 2023 •
edited
Loading

  • added a contribution section to the README
  • added a local workflow to help test changes
  • made the vault token configurable for tests so people can run acc tests against their already-running vault instance
  • bumped the action/checkout version,
  • use the ref param to checkout the branch that created the event so the acceptance tests use the PR code and not the default branch, I believe at the moment this is causing the CI checks to pass even if the code introduces regressions

@maxcoulombe
+ added a contribution section to the readme
2b790b4 
+ added a local workflow to test changes
+ made the vault token configurable for tests
@maxcoulombe
* bumped action/checkout
de09201
fairclothjm
fairclothjm approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxcoulombe maxcoulombe merged commit 3bbbc68 into main Feb 28, 2023
@maxcoulombe maxcoulombe deleted the development-flow-enhancements branch February 28, 2023 20:28
TomNorth pushed a commit to TomNorth/vault-action that referenced this pull request Mar 25, 2023
@maxcoulombe @TomNorth
Development flow enhancements (hashicorp#430)
1b1f02e 
+ added a contribution section to the readme
+ added a local workflow to test changes
+ made the vault token configurable for tests
* bumped action/checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

@jasonodonnell jasonodonnell Awaiting requested review from jasonodonnell

@tomhjp tomhjp Awaiting requested review from tomhjp

@vinay-gopalan vinay-gopalan Awaiting requested review from vinay-gopalan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxcoulombe @fairclothjm