Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle undefined response in getSecrets error handler #431

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Handle undefined response in getSecrets error handler #431

merged 1 commit into from
Mar 2, 2023

Conversation

mldahl
Copy link
Contributor

@mldahl mldahl commented Feb 28, 2023

Handle errors without a response property. Testing against a vault with self signed certs w/out providing the caCertificate input.

Before:
image

After:
image

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mldahl mldahl mentioned this pull request Feb 28, 2023
Closed
maxcoulombe
maxcoulombe approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@maxcoulombe maxcoulombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this quick fix! Make a lot of sense.

@maxcoulombe maxcoulombe merged commit 256bfb9 into hashicorp:main Mar 2, 2023
TomNorth pushed a commit to TomNorth/vault-action that referenced this pull request Mar 25, 2023
@mldahl @TomNorth
handle undefined response in getSecrets error handler (hashicorp#431)
e5f1a49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcoulombe maxcoulombe maxcoulombe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mldahl @hashicorp-cla @maxcoulombe