-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add PKI capability #564
Conversation
Hey @snocorp, apologies for the silence on this, and thanks for the contribution. I know we were a bit worried about breaking the restriction on I'll give the code a look over and hopefully we can get this in sooner rather than later! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kpcraig Thanks for reviewing this one. I don't see the related changes to dist/index.js in this PR so we will need to make sure to make that change before we do the release. |
@fairclothjm Thanks, I didn't realize that was part of the PR process but in retrospect it makes sense. Would it be helpful if I created a new PR for that? I'd love to get a new release so we can start to use it internally. |
@kpcraig @fairclothjm I've created #568 to update the build output in case that helps to get the next release out. |
Description
Add the ability to generate PKI certificates from Vault's PKI engine. You can now use the
pki
option to generate a certificate and private key for a given role.Checklist
Community Note
reaction
to the original pull request comment to help the community and maintainers
prioritize this request
followers and do not help prioritize the request