Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration for active/standy services for server #546

Conversation

jamesgoodhouse
Copy link

@jamesgoodhouse jamesgoodhouse commented Jun 4, 2021

Currently there is no ability to configure services for active and standby services, as they inherit their settings from the main server service configuration. This is a problem, for example, when you need to attach different annotations to the different services. Instead of just allowing for setting of annotations, I opted to allow configuring the services for more flexibility.

@jamesgoodhouse jamesgoodhouse force-pushed the allow_config_for_standby_and_active_services branch 4 times, most recently from e406943 to 1a36d8f Compare June 4, 2021 18:43
@jamesgoodhouse jamesgoodhouse force-pushed the allow_config_for_standby_and_active_services branch from 1a36d8f to c7d9077 Compare June 4, 2021 18:50
@jamesgoodhouse jamesgoodhouse marked this pull request as ready for review June 4, 2021 18:54
@velkovb
Copy link

velkovb commented Aug 15, 2021

This would solve #588

@jimsnab
Copy link

jimsnab commented Oct 7, 2021

I like this change and I think it should be merged, but someone more qualified than me needs to review it.

@tvoran tvoran added enhancement New feature or request vault-server Area: operation and usage of vault server in k8s labels Jan 6, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@eye0fra
Copy link

eye0fra commented Mar 14, 2022

Related #674

@jamesmbourne
Copy link

This would be really helpful - we are facing this same issue meaning multiple load balancers are provisioned without any mechanism to control which services they are linked with.

@peikk0
Copy link

peikk0 commented Apr 21, 2022

Any update on this? I would also find this change helpful to be able to set annotations for a particular service.

Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going, especially with the annotations, but we'll want to make sure we're backwards compatible (unless there is a dire reason we can't).

I can see where the annotations are useful, but Is the clusterIP / nodePort override behavior also useful for people?

@@ -13,20 +13,26 @@ metadata:
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
annotations:
{{ template "vault.service.annotations" .}}
{{ template "vault.service.active.annotations" .}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to include the previous annotations as well in both the active and standby. (Both because of backwards compatibility and because we might want to have common annotations in the vault.service.annotations template.)

"active": {
"type": "object",
"properties": {
"annotations": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These appear to be missing entries for type, nodePort, clusterIP`.

@@ -459,6 +459,52 @@ server:
# to the service.
annotations: {}

# Enables a headless service that contains the active pod only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sections don't enable this behavior, so I would remove this comment.

@@ -459,6 +459,52 @@ server:
# to the service.
annotations: {}

# Enables a headless service that contains the active pod only
active:
# clusterIP controls whether a Cluster IP address is attached to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment about these values defaulting to the values.server.service values if missing, except annotations (which will be appended)?

@tekicat
Copy link
Contributor

tekicat commented May 19, 2023

Revived this PR in #896

@tvoran
Copy link
Member

tvoran commented Oct 12, 2023

Superseded by #896

@tvoran tvoran closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vault-server Area: operation and usage of vault server in k8s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants