Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add podSelector for networkPolicy #877

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

fty4
Copy link
Contributor

@fty4 fty4 commented Apr 14, 2023

Hello everyone,

I'd like to have the option to limit which pods are allowed to access the Vault instance.
Therefore the NetworkPolicy should be expandable to support a custom podSelector (matchLabels).

Currently (and now with the default values) the Vault pod can be reached by any other pod.


Marco Lecheler marco.lecheler@mercedes-benz.com Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

@fty4 fty4 requested a review from a team April 14, 2023 07:45
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 14, 2023

CLA assistant check
All committers have signed the CLA.

values.yaml Outdated Show resolved Hide resolved
As suggested let users template the whole ingress object for the networkPolicy than only the podSelector.

Co-authored-by: tvoran <444265+tvoran@users.noreply.github.com>
@fty4 fty4 requested a review from tvoran July 28, 2023 06:49
@tvoran tvoran added this to the v0.27.0 milestone Nov 15, 2023
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvoran tvoran merged commit e77dce3 into hashicorp:main Nov 16, 2023
@fty4 fty4 deleted the feat/netpol-podSelector branch November 16, 2023 06:14
@tvoran tvoran mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants