Add MaxConnectionsPerHost to Agent Injector #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
changed the title
VioletHynes
reviewed
Jan 18, 2024
tvoran
reviewed
Jan 22, 2024
tvoran
reviewed
Jan 23, 2024
tvoran
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashicorp/consul-template#1858 introduced the ability to specify the maximum amount of connections allowed per Vault host within a Vault client's Transport configuration. The ability to specify this within Vault Agent was then introduced in hashicorp/vault#24548.
This PR adds support for
max_connections_per_hostwithin Agent injector. Along with adding support, a change was introduced to move away from thestrconvparse functions in favor ofgithub.com/hashicorp/go-secure-stdlib/parseutil.