turn on GO111MODULE in build #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaizhe <derek0405@gmail.com>
|
|
Makefile
Outdated
| @@ -13,6 +13,7 @@ BIN_NAME=$(IMAGE_NAME)_$(GOOS)_$(GOARCH)_$(VERSION) | |||
| all: build | |||
|
|
|||
| build: | |||
| export GO111MODULE=on | |||
There was a problem hiding this comment.
Is export really needed or could this be prepended to the go build command like the other envs?
Signed-off-by: kaizhe <derek0405@gmail.com>
Merged
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
* turn on GO111MODULE in build Signed-off-by: kaizhe <derek0405@gmail.com> * remove export Signed-off-by: kaizhe <derek0405@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kaizhe derek0405@gmail.com
turn on
GO111MODULEin case it is not set in people's env.