Updates the hashicorp/cap library to v0.1.0 for verification key caching fix #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you run |
calvn
approved these changes
Jun 4, 2021
pcman312
approved these changes
Jun 4, 2021
austingebauer
added a commit
that referenced
this pull request
Jun 7, 2021
austingebauer
changed the title
austingebauer
added a commit
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the hashicorp/cap library to v0.1.0 to bring in a verification key caching change in the underlying
coreos/go-oidclibrary. The library now follows a strategy that is more aligned with the OIDC spec.For more details, see the following issues/PRs:
Testing
All existing tests are passing after this update. I also manually tested that JWT verification works as expected.