Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure provider - Add Support for US Gov L4 #211

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

MarkDordoy
Copy link
Contributor

@MarkDordoy MarkDordoy commented Jul 25, 2022

The azure provider has some code to correctly identify and convert the Azure AD Graph host to the MS Graph host. For reasons unknown to me, Microsoft will not update the JWT to correctly send MS Graph URLs even though AD Graph is deprecated.

This PR extends the current conversion to support the US Gov cloud offering (https://docs.microsoft.com/en-us/graph/migrate-azure-ad-graph-request-differences)

@MarkDordoy
Copy link
Contributor Author

@austingebauer tagging as i see you recently reviewed a previous PR. Sorry for direct tag.

@austingebauer austingebauer self-requested a review July 26, 2022 17:04
provider_azure.go Outdated Show resolved Hide resolved
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again, @MarkDordoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants